Flyspray - The bug killer!

“If debugging is the process of removing bugs, then programming must be the process of putting them in.” – Edsger Dijkstra

This is the Bug Tracking System for the Flyspray project. This is not a demo! Before opening a new task, please read the guidelines!

Do not issue bugs reports against versions earlier than 0.9.9.5

Security problem? Check the security section.

Tasklist

FS#1480 - Assignee list should not display disabled users

Attached to Project: Flyspray - The bug killer!
Opened by Romain Riviere (Mr_Smoke) - Tuesday, 29 April 2008, 15:10 GMT+2
Task Type Bug Report
Category Database Queries
Status Unconfirmed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version 1.0.0 devel
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Whenever an assignee list is available, flyspray does some smart thinking to determine who should appear first. However, I believe that the disabled accounts should not appear in the default list, unless the user specifically clicks the Disabled group. Maybe that’s just me :P

This can be fixed by changing line 90 in scripts/userselect.php so that : 

            $users = $db->x->getAll('SELECT a.user_id, u.user_name, u.real_name, email_address,
                                            count(a.user_id) AS a_count, CASE WHEN t.project_id = ? THEN 1 ELSE 0 END AS my_project
                                       FROM {assigned} a
                                  LEFT JOIN {users} u ON a.user_id = u.user_id
                                  LEFT JOIN {tasks} t ON a.task_id = t.task_id
                                      WHERE ( ' . $where . ' )' . '
                                   GROUP BY a.user_id
                                   ORDER BY my_project DESC, a_count DESC', null, array_merge(array($proj->id), $params));

becomes 

            $users = $db->x->getAll('SELECT a.user_id, u.user_name, u.real_name, email_address,
                                            count(a.user_id) AS a_count, CASE WHEN t.project_id = ? THEN 1 ELSE 0 END AS my_project
                                       FROM {assigned} a
                                  LEFT JOIN {users} u ON a.user_id = u.user_id
                                  LEFT JOIN {tasks} t ON a.task_id = t.task_id
                                      WHERE ( ' . $where . ' )' . ' AND u.account_enabled = 1
                                   GROUP BY a.user_id
                                   ORDER BY my_project DESC, a_count DESC', null, array_merge(array($proj->id), $params));

(sorry, don’t have GNU patch here at the moment, hope it’s ok)

This task depends upon

Loading...