Flyspray - The bug killer!

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Backend/Core
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version 0.9.9-devel
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Flyspray - The bug killer!
Opened by Kawashima Takahiro - 06.11.2006

FS#1107 - Cannot search by item_status == 8

I'm using latest 0.9.9 branch (r851).

In task list page, search by a particular status always displays all tasks as result.
"a particular status" is a status which has ID of '8'.

get_task_list function of class.backend.php has following code (line 1080).
I think latter half of first if-condition is unnecessary.
What's that condition? A bug introduced in  FS#287 ?

                if (is_numeric($val) && !is_array($db_key) && !($key == 'status' && $val == '8')) {
                    $temp .= ' ' . $db_key . ' = ?  OR';
                    $sql_params[] = $val;
                } elseif (is_array($db_key)) {
                    if ($key == 'dev' && ($val == 'notassigned' || $val == '0' || $val == '-1')) {
                        $temp .= ' a.user_id is NULL  OR';
                    } else {
                        if (!is_numeric($val)) $val = '%' . $val . '%';
                        foreach ($db_key as $value) {
                            $temp .= ' ' . $value . ' LIKE ?  OR';
                            $sql_params[] = $val;
                        }
                    }
                }
Closed by  Florian Schmitz
07.11.2006 16:19
Reason for closing:  Fixed in devel
Additional comments about closing:  

thanks for pointing me at the possible error source. rev 854

Kawashima Takahiro commented on 06.11.2006 15:53
get_task_list function of class.backend.php has following code (line
line number is 993, not 1080.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing