Flyspray - The bug killer!

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Notifications
  • Assigned To
    Jouni Ahto
  • Operating System All
  • Severity Medium
  • Priority Low
  • Reported Version 0.9.9.5 devel
  • Due in Version 1.0
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Flyspray - The bug killer!
Opened by Christoph J√ľngling - 14.11.2008
Last edited by peterdd - 04.08.2015

FS#1517 - Jabber configuration prevents scheduler from sending mails

An existing Jabber configuration in the admin backend prevents the scheduler from sending mails, deleting the Jabber account data let it work again. Anyway, the normal messages in case of a task's changes are sent properly with or without the Jabber configuration.

Closed by  peterdd
04.08.2015 20:23
Reason for closing:  Fixed in devel
Additional comments about closing:  

schedule.php called by cronjob now works again for
system email+jabber and user email+jabber setting.

Admin
Florian Schmitz commented on 18.04.2009 10:18

Please provide some details on your configuration and possibly PHP error log information. E-mails are actually sent before Jabber notifications, so they shouldn't be able to prevent them.

Project Manager
peterdd commented on 31.07.2015 04:04

There seems to be some logic errors in schedule.php, for which I setup a cronjob calling every 5 minutes.

Hope this fixes it:

if ( ( $fs->prefs['user_notify']==1 || $fs->prefs['user_notify']==2 ) && ( $row['notify_type']==1 || $row['notify_type']==3 ) ) {
  $email_users[] = $row['email_address'];
}

if ( ( $fs->prefs['user_notify']==1 || $fs->prefs['user_notify']==3 ) && ( $row['notify_type']==2 || $row['notify_type']==3 ) ) {
  $jabber_users[] = $row['jabber_id'];
}

Sadly different meaning of the values!! :

system setting: "user_notify": 0=no, 1=both, 2=emailonly, 3=jabberonly
user setting: "notify_type": 0=no, 1=emailonly, 2=jabberonly, 3=both

Now I get the notifications by email, but my cron sends error reports too, related to php here is < php5.4:

PHP Notice: Use of undefined constant ENT_HTML401 - assumed 'ENT_HTML401' in /..../flyspray/includes/class.notify.php on line 426

Notice: Use of undefined constant ENT_HTML401 - assumed 'ENT_HTML401' in /..../flyspray/includes/class.notify.php on line 426
Jouni Ahto commented on 31.07.2015 14:25

Ok, I can look for this one as requested, but Peter, you could also assign this one to yourself. Because you are actually using reminders, have a jabber account somewhere for testing and already have half of the fix ready. It might look like I'd have modified those lines you fixed, no, just changed formatting and hoped that the logic is right.

Now then if you get the message in a wrong language, that's another bug that should be opened and assigned to me.

Project Manager
peterdd commented on 02.08.2015 10:59

I didn't want to "steal" it from you. :-)
And I assigned me to many other open tasks too.

I will test a little bit more and then close it.

Project Manager
peterdd commented on 04.08.2015 20:20

Yeah! Reminder works and I finally receive my daily scheduled reminders by email and jabber client. :-)

Settings for jabber need some documentation (tooltip) and a "Test jabber connection now button" for jabber newbies like me. :-) But thats another task.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing