• Status Confirmed
  • Percent Complete
  • Task Type Bug Report
  • Category Backend/Core
  • Assigned To No-one
  • Operating System All
  • Severity Medium
  • Priority Low
  • Reported Version
  • Due in Version 1.1 devel
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Flyspray
Opened by allo - 12.04.2013

FS#1861 - Login-Page should redirect after login to the page, the user wanted to see

When some url to a bug is redirected to the login page, because the user does not have the right to see the bug without login, the user should be redirected after the login to the url he wanted to see.

Maybe redirect to /login/?next=/task/X and put the next-url in a hidden field in the login-form, so flyspray can redirect to the correct page after login.
Even preserving anchor-urls (#comment-YYYY) would be cool, but i guess this needs Javascript to work.

Project Manager

Mmh, for example sharing a bug accessible only for users with access right to view the task /index.php?do=details&task_id=1

Instead of forcing a HTTP Redirect in scripts/details.php at line 21

if (!$user->can_view_task($task_details)) {
    Flyspray::show_error( $user->isAnon() ? 102 : 101);

replacing it with showing only the error message does the trick.

if (!$user->can_view_task($task_details)) {
    Flyspray::show_error( $user->isAnon() ? 102 : 101, false);
} else {
    ...code till end of file...
} # end the new else at end of file

I will not add this to github master at this moment, need some researching about possible (security) implications before doing it.

Project Manager

Reminder sends (jabber and emails) links of the reminded tasks, so it happens quite often ⇒ raised priority

Project Manager

Done for links leading to tasks.
Links with #anchor keeping should be no extra problem.

Next todo: links to /?do=newtask and /?do=newtask&project=?

Project Manager

A user reported problems with the return_to redirect when Flyspray is behind a reversed proxy.
(Flyspray up to 1.0-rc6, current '1.0-rc7 dev' too)


Available keyboard shortcuts


Task Details

Task Editing