Flyspray - The bug killer!

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Backend/Core
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version 1.0 devel (github master)
  • Due in Version 1.0
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Flyspray - The bug killer!
Opened by peterdd - 07.03.2015
Last edited by peterdd - 20.03.2015

FS#1953 - do form actions first, then build the anwser page

If you save forms, it can happen that something is changes on the page. ^^

But if you render parts of the answer page before the form action is handled and database changes are made,
the answer page shows old information. Only on an additional request you see the current data.

The wrong way to solve this is making a redirect. Saw this in some other software and it was source of problems.

Closed by  peterdd
20.03.2015 23:22
Reason for closing:  Fixed in devel
Project Manager
peterdd commented on 09.03.2015 11:06

I think I got it resolved now for 1.0.

But we have to review this:

Some actions handlers write message strings to

$_SESSION

and then do a HTTP redirect. In the redirect the message stored in $_SESSION is used to display a message for the user.

But now that the actions are always handled before creation of the return page, we can write the message direct into the return page whitout a redirect or storage into $_SESSION.

So I set it only to 70% complete to think about if we replace existing redirects by creating the answer page or keeping as it is. Both ways works. But HTTP redirecting needs one extra roundtrip between server and webbrowser.

Project Manager
peterdd commented on 20.03.2015 23:21

A message stored in $_SESSION is used for display on direct output too, so no big problem.

3 outputs also removed from modify.inc.php now, so I will close this task now.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing