Flyspray - The bug killer!

  • Status Closed
  • Percent Complete
    100%
  • Task Type TODO
  • Category Notifications → Email
  • Assigned To
    Jouni Ahto
    peterdd
  • Operating System All
  • Severity High
  • Priority Low
  • Reported Version 1.0 devel (github master)
  • Due in Version 1.0
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Flyspray - The bug killer!
Opened by peterdd - 07.03.2015
Last edited by Jouni Ahto - 23.04.2015

FS#1954 - Change "No HTML in E-Mails" Option

Emails should be sent in both formats within one Email, not either text or HTML.

It is the choice of the users email program if he sees the messages as html or plain text.

So in best case we can drop this option when implemented and make Flyspray a bit more easier to administer?

Closed by  Jouni Ahto
23.04.2015 08:37
Reason for closing:  Implemented in devel
Project Manager
Psychokiller1888 commented on 07.03.2015 10:57

Totally agree. Should be made for 1.1

Project Manager
peterdd commented on 20.03.2015 06:50

Wtf, when testing new user registration!

It seems to send the wrong email and the email formatting (text? html?) is totally broken.

Jouni Ahto commented on 20.03.2015 09:10

This might be somewhat related to currently half-broken notification/registration system. I'm really working on it as fast as I can.

Project Manager
Psychokiller1888 commented on 20.03.2015 09:13

Yeah, the whole confirmation after account creation appears above the header since a while now... Same goes after you gave your email code in or any other registration type

Project Manager
peterdd commented on 20.03.2015 14:30

Since when?

Project Manager
peterdd commented on 20.03.2015 16:35

This is the raw email received by the admin.

Return-Path: < ***cutoff*** >
X-Original-To: ***adminemailaddress***
Delivered-To: ***cutoff***
Received: by ***cutoff***
To: ***adminemailaddress, newuseremailaddress***
Subject: Flyspray Benachrichtigung
X-PHP-Originating-Script: 6833:SimpleMailInvoker.php
Message-ID: < ***cutoff*** >
Date: Fri, 20 Mar 2015 05:54:06 +0000
From: Alle Projekte < ***anotheradminemailaddress*** >

2 of my email addresses?

MIME-Version: 1.0
Content-Type: text/html; charset=utf-8

I can review this. I maintain a php written webshop software and we send our automated notification mails to customers always as text AND html.

Content-Transfer-Encoding: quoted-printable
X-Mailer: Flyspray
Precedence: list

Ein neuer Benutzer hat sich an Ihrer Flyspray-Instanz mit folgenden Benu=
tzerdaten registriert:  Benutzername: tester3vollst=C3=A4ndiger Name: tes=
ter3E-Mail: ***newuseremailaddressJabber-ID:Dies ist eine Nachricht vom Flyspra=
y Bugtracking-System auf ***domain***/flyspray-master/. Sie erhalt=
en diese Nachricht, weil Sie in Flyspray Benachrichtigungen aktiviert ha=
ben. Wenn Sie zuk=C3=BCnftig keine solchen Benachrichtigungen mehr erhalt=
en wollen, k=C3=B6nnen Sie die Einstellungen f=C3=BCr Benachrichtigung=
en =C3=BCber die obenstehende URL =C3=A4ndern.

This seems like if just html tags stripped without giving an alternative textonly formatting.

Jouni Ahto commented on 20.03.2015 17:41

See commit SHA1 ID 17fdfaf540b816242477879a1ca829613ccaa1ef.

Jouni Ahto commented on 20.03.2015 17:55

If my latest commit and pull request works, I'll read swiftmailer documentation quickly through on the weekend. And make this option to mean just that no html-part is sent, otherwise both.

Project Manager
peterdd commented on 20.03.2015 17:56

i made changes too! see my install-hack branch!

Project Manager
peterdd commented on 20.03.2015 18:22

With default settings the user registration flow seems a bit better.

But with this settings as you can see in the screenshot I got the ugly htmlcontent before page begins.
And the registration mail of the new user get the same email content of the notification as the admin.

Project Manager
peterdd commented on 20.03.2015 18:27

My patch seems to work:

Content-Type: multipart/alternative;
 boundary="_=_swift_v4_1426875912_4158982f10f5d2a814de025a8c92d933_=_"
X-Mailer: Flyspray
Precedence: list


--_=_swift_v4_1426875912_4158982f10f5d2a814de025a8c92d933_=_
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ein neuer Benutzer hat sich an Ihrer Flyspray-Instanz mit folgenden Benu=
tzerdaten registriert: =20

Benutzername: tester2
volls=
t=C3=A4ndiger Name: tester2
E-Mail: ****
Jabber-ID=
:

Dies ist eine Nachricht vom Flyspray Bugtracking-System auf h=
ttp://***/. Sie erhalten diese Nach=
richt, weil Sie in Flyspray Benachrichtigungen aktiviert haben. Wenn Sie=
 zuk=C3=BCnftig keine solchen Benachrichtigungen mehr erhalten wollen=
, k=C3=B6nnen Sie die Einstellungen f=C3=BCr Benachrichtigungen =C3=BCber d=
ie obenstehende URL =C3=A4ndern.

--_=_swift_v4_1426875912_4158982f10f5d2a814de025a8c92d933_=_
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ein neuer Benutzer hat sich an Ihrer Flyspray-Instanz mit folgenden Benu=
tzerdaten registriert:  <br><br>Benutzername: tester2<br>vollst=C3=A4ndig=
er Name: tester2<br>E-Mail: ***<br>Jabber-ID:<br><br>Dies i=
st eine Nachricht vom Flyspray Bugtracking-System auf <a href=3D"http://***/.">***/.</a> Sie erhalten diese Nachricht, weil Sie in Flyspray Bena=
chrichtigungen aktiviert haben. Wenn Sie zuk=C3=BCnftig keine solchen Ben=
achrichtigungen mehr erhalten wollen, k=C3=B6nnen Sie die Einstellungen f=
=C3=BCr Benachrichtigungen =C3=BCber die obenstehende URL =C3=A4ndern.

--_=_swift_v4_1426875912_4158982f10f5d2a814de025a8c92d933_=_--


Project Manager
peterdd commented on 20.03.2015 19:03

Ok, now that text/html is fixed in dev and in both cases a plain text version is sent too:

This option could be a good candit for removing when reviewing flyspray as a whole for how to make flyspray even more simplier and easier without losing important features.

In what use cases is not sending html notification in addition to plain text wanted?
Safing a view bytes in mailboxes in case of using flyspray in an automated machine environment?

For the other issues discussed here maybe create own tasks.

Jouni Ahto commented on 20.03.2015 19:13

Yes, own tasks for further issues. This one can be closed.

Project Manager
peterdd commented on 20.03.2015 23:00

Ok, wrong output on page when registering under special flyspray settings fixed (pull request github).

Now only review that the notification mail under this flyspray setting is sent as one email to admins and the new user.

(All? recipients are in the TO: -field of the email the admins email and the newusers email)

Maybe the new user should only see a email address of the flyspray admin in the FROM-field, and only his own email address in the FROM-field.

Otherwise its is good to see for the new user, that that email is sent to the flyspray admin too?

Project Manager
peterdd commented on 21.03.2015 00:40

Last thing before closing: We should a tooltip (title-tag) explaining the exact meaning of the option at the admin area for this option/label.

Jouni Ahto commented on 23.04.2015 08:37

I think the last one should be added as new task "Add tooltips". We don't have much of them. So I'm closing this to make roadmap for 1.0 look better.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing