- Status Researching
- Percent Complete
- Task Type Bug Report
- Category Backend/Core
- Assigned To No-one
- Operating System All
- Severity Medium
- Priority Low
- Reported Version 1.0-rc
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Flyspray - The bug killer!
Opened by peterdd - 15.04.2016
Last edited by peterdd - 15.04.2016
Opened by peterdd - 15.04.2016
Last edited by peterdd - 15.04.2016
FS#2119 - function filter_input not always available
filter_input() is in extension “Filter”.
It is enabled by default since PHP5.2, see http://php.net/manual/en/migration52.new-extensions.php but not “always”, see https://groups.google.com/forum/?hl=de#!topic/flyspray/QM75BvwPqGM
filter_input() is only used at 1 section in Flyspray (since 2014 up to v1.0rc1) in includes/fix.inc.php
This is the commit https://github.com/Flyspray/flyspray/commit/40861911260812c99682fe3456350cb63bb243a9
How do we solve it? Several possibilities:
- Do we really need this calls here? What “bad input” is filtered here?
- Test if the extension is enabled at install/update tests/screens.
- use function_exists() test at every request ( similiar to the source code before https://github.com/Flyspray/flyspray/commit/40861911260812c99682fe3456350cb63bb243a9 )