- Status Closed
- Percent Complete
- Task Type Feature Request
- Category Installer and Upgrader
- Assigned To No-one
- Operating System Linux
- Severity Medium
- Priority Very Low
- Reported Version 1.0-rc9
- Due in Version Undecided
-
Due Date
Undecided
-
Votes
1
- Olivier Humbert (30.08.2019)
- Private
Opened by Olivier Humbert - 30.08.2019
Last edited by peterdd - 08.12.2019
FS#2566 - syntax_plugin after an upgrade from 0.9.9.7 -> 1.0-rc9
database: mysql - version: 5.5.62-0+deb8u1
php version: 5.6.40
Debian (probably a Buster one)
Steps done to create the problem: I used to run a 0.9.9.7 version, and today, I decided to go for a 1.0-rc9 update.
Expected behavior: all works
Experienced behavior: most works, but not all
Details: after the update, I had weird display behaviour where the task weren’t displaying breaklines:
http://pix.toile-libre.org/upload/original/1567183628.png
while the code was supposed to have breaklines:
http://pix.toile-libre.org/upload/original/1567183667.png
Then, I’ve read: https://bugs.flyspray.org/index.php?do=details&task_id=2318 which leads me to: https://github.com/Flyspray/flyspray/blob/master/setup/templates/administration.tpl#L49
Then, I’ve changed
syntax_plugin="none"
for
syntax_plugin="dokuwiki"
in flyspray.conf.php, and now all is fine:
http://pix.toile-libre.org/upload/original/1567183768.png
I’m already enjoying bold/italic/code/… very nice addition from 0.9.9.7, thank you!
That said, something which looks to be an issue from my (user) perspective is that when upgrading from 0.9.9.7 → 1.0-rc9, I wasn’t asked for a “syntax plugin” thing and it looks that the only way to change it so far is to CLI-edit the flyspray.conf.php file.
I would strongly suggest to make this an option in the admin panel.
Thanks for flyspray that I’m using fo my librazik project.
All the best,
Olivier
08.12.2019 03:00
Reason for closing: Fixed in devel
Additional comments about closing:
nl2br() used again for syntax_plugin
'none'
First (nonfunctional) link should have been: http://pix.toile-libre.org/upload/original/1567183628.png
Link fixed.
Are you sure you run PHP 4.3.9 on a Debian 10 Buster?
Flyspray 1.0-rc9 current minimal support is PHP 5.4 and my Debian 10 (Buster) vagrant boxes have PHP 7.3.4-2 by default ..
Well, the reason why there is no easy option for toggling syntax_plugin setting just in admin panel is that they work quite differently behind the curtain and would require complex conversions to do it correctly. (and cannot be reversed in some cases like nested html tags to dokuwiki back to html not possible)
none and html just store the descriptions and other text fields (hopefully full) sanitized when saving in database and later outputed.
dokuwiki syntax_plugin instead is stored ‘as is’ in database, parsed later and final html rendered before output and is more flexible to extended (like adding a user mention plugin or other things)
Having these different systems in Flyspray is not optimal, and there also exist some related tasks like FS#2052 .
Thank you.
My bad, 4.3.9 is the version of phpmyadmin. PHP is 5.6.40-0+deb8u5 .
Thanks for you explanation.
I'd like to add a question then: how is that possible that 0.9.9.7 was fine, then the update to 1.0-rc9 with
gave me a badly formated text in the tasks? Shouldn't it be considered as a bug maybe, what do you think?
Maybe this commit
https://github.com/Flyspray/flyspray/commit/021378641b40eed2a805fdb8c040430f145be9d5#diff-d1cd0bd01e5e20f4a45d352071dd35c1
that removed the nl2br call there. They had obviously not the 'none'
option for syntax_plugin in mind.
https://github.com/Flyspray/flyspray/commit/021378641b40eed2a805fdb8c040430f145be9d5#diff-d1cd0bd01e5e20f4a45d352071dd35c1
The TextFormatter::render() now uses nl2br() when syntax_plugin is '' or 'none'.
The call was there, but commented out. This was probably a leftover from former devs who thought html/CKEditor will be the only option.