Flyspray - The bug killer!

  • Status New
  • Percent Complete
    80%
  • Task Type TODO
  • Category Backend/Core
  • Assigned To
    peterdd
  • Operating System All
  • Severity Low
  • Priority Medium
  • Reported Version 1.0-rc9
  • Due in Version 1.0-rc10
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Flyspray - The bug killer!
Opened by peterdd - 12.12.2019
Last edited by peterdd - 13.04.2021

FS#2586 - PHP7.4

PHP 7.4 is out now and a few things should be done to make Flyspray work well with it.
Nothing really breaks, but a view deprecation warnings should be fixed.

Flyspray source itself: Just a few new notices, most are yet fixed in the master branch.

Watching the PHP7.4 compatibility of dependencies defined by composer.json:

  • ADOdb/ADODb: 5.21 for PHP 8 done
  • swiftmailer/swiftmailer: We still use 5.* branch, so either do quickfix for a notice in a fork or upgrade/rewrite our integration to the 6.* branch. 6.* is PHP7+, so stay with 5.* branch for now. If Swiftmailer does not fulfill requirements, consider switching to PHPMailer for FS1.1+
  • ezyang/htmlpurifier: 4.13 OK
  • thephpleague/oauth2-client: unknown, we still use 0.13, last real source change was Nov 2018, to upgrade requires rewrite of integration into Flyspray and there is low demand for OAuth2.
  • dapphp/securimage: seems to be OK, but not maintained anymore (we could patch it if there occur problems in future)
  • jamiebicknell/sparkline: OK, but probably obsolete for us in future due
    • still annoying problems with our github/travis tests (problem of travis, not sparkline itself)
    • better solution (interactive hover infos, scales, screen size adaptive) by Flyspray source planned
The task depends upon
ID Project Summary Priority Severity Assigned To Progress
2621 Flyspray - The bug killer! FS#2621 - php notice/warning when reopening in some circumstances Medium Medium peterdd
0%
aducom commented on 08.02.2020 11:36

Perhaps related, but under php 7.4 I get the message:
Notice: Trying to access array offset on value of type bool in /home/…./domains/phspeed.com/private_html/bt/scripts/details.php on line 649

Project Manager
peterdd commented on 14.02.2020 19:23
Notice: Trying to access array offset on value of type bool in /home/…./domains/phspeed.com/private_html/bt/scripts/details.php on line 649

I think I fixed this with https://github.com/Flyspray/flyspray/commit/b97fdab04cf1440dcb8cebb112406f2d6f9ac2ce#diff-e9cd040cbf7b7db6a5501bf44c3700b9 on the github master branch in December 2019.

Project Manager
peterdd commented on 17.02.2020 16:30

Not yet fixed in master branch when deleting a task comment: 

Notice: Trying to access array offset on value of type bool in /xxx/includes/modify.inc.php on line 2356
Notice: Trying to access array offset on value of type bool in /xxx/includes/modify.inc.php on line 2357
Notice: Trying to access array offset on value of type bool in /xxx/includes/modify.inc.php on line 2357


Reference links:
https://github.com/Flyspray/flyspray/commit/8d47ea60aab626b92bbb2091e3292e763e62e799

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing