Flyspray - The bug killer!

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Bug Report
  • Category User Interface
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version 1.0-rc9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Flyspray - The bug killer!
Opened by paulfertser - 28.12.2019

FS#2589 - Time zone in user settings is confusing

Hello,

When registering and when later editing users settings it’s possible to specify “Time zone” but the way it’s implemented is confusing. What I see is a drop-down list with GMT[+-]:digit: and this is an odd way to set the timezone for multiple reasons:

1. “GMT” is a word without universally accepted and defined meaning these days, see https://www.ucolick.org/~sla/leapsecs/timescales.html#GMT ;

2. Often time zone specification needs to include the rules when (if ever) to apply DST and what abbreviation is to be used in different cases. See TZ description on https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 .

Taking these two points into account I can’t see how to meaningfully use this feature.

TIA for looking into it.

paulfertser commented on 28.12.2019 18:10

For me it's not a matter of complete/incomplete as in #2200 or wrong as in #1856 as it's absolutely unclear what it means (so no way to judge the behaviour unless one digs the sources to see what exactly and how exactly the setting is applied).

Project Manager
peterdd commented on 28.12.2019 20:37

See the 'GMT' as outdated synonym for UTC.

I changed it for myself for the german language, but unsure what other languages prefer. (or if it even is necessary to have this translatable) 

flyspray/lang>grep -n GMT *.php
bg.php:791:'GMT'                     => 'GMT',
cz.php:802:'GMT'                     => 'GMT',
de.php:841:'GMT'                     => 'UTC',
dk.php:787:'GMT'                     => 'GMT',
el.php:838:'GMT'                     => 'Ώρα Γκρήνουιτς',
en.php:847:'GMT'                     => 'GMT',
...

Timestamps like for the due date are unix timestamps (but currently stored as integers in the Flyspray database). This is assumed as UTC+0

There is not much usage of the user's stored time_zone field. There are currently only 3 locations in the source code where it is used for calculation:

  • Flyspray::strtotime() in includes/class.flyspray.php
  • tpl_datepicker() in includes/class.tpl.php
  • formatDate() in includes/class.tpl.php which is used by the theme templates

The time_zone field in the users table is currently also an integer field, so can contain currently only full hour offsets and not real country timezones.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing