- Status Researching
- Percent Complete
- Task Type Bug Report
- Category Javascript
-
Assigned To
peterdd - Operating System All
- Severity Medium
- Priority Low
- Reported Version 1.0-rc10
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#2639 - Unable to "deny" a pending request
My project has 37 pending requests. Each has a set of Accept / Deny buttons next to it.
If I click on Deny, a textbox pops up for me to enter “Reason for denial” but the entire page immediately regreshes/reloads back to the task list before I have a chance to enter the reason and submit it.
I can always “Accept” the request implicitly by going to the appropriate task and closing/re-opening it, but there’s no way to “deny” something without going through this UI path.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Couldn't reproduce with just 1 pending request with Firefox 88, Chrome 90 and Safari on older Mac.
Could you please provide OS and Browser version?
Probably similiar problem to
FS#2037, the preventDefault() so the onclick event handled first but the browser schould not open the a href link.https://github.com/Flyspray/flyspray/blob/master/themes/CleanFS/templates/pm.pendingreq.tpl
Also the Accept and Deny buttons should have a hint that it is a 2 step operation with selecting reason (accept) and comment (accept and deny)
So maybe Accept … and Deny … label for the first step buttons.
I'm using Firefox 88.0 on Linux (more specifically, Fedora 34)
(FWIW, this was also broken in -rc9, albeit with slightly different behavior..)
It also shows the same buggy behavior using a pristine Chromium 90.0.4430.93 instance (Also Fedora 34)
Do you see any Javascript warnings/errors in the browser developer console?
Nothing that is obviously from flyspray. On each page load I see this:
AbortError: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved ConduitsParent.jsm:297
And several of theses:
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. background_firefox.js:283
That is in Firefox. On Chromium I see nothing showing up in the JS console.
Another observation – a similar bug affects requesting ticket closure (or re-opening) – page refreshes immediately.